Skip to content

dird: console: add jobtype parameter to list jobs#1149

Merged
pstorz merged 9 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/s5120-llist-jobs-jobtype
Apr 6, 2022
Merged

dird: console: add jobtype parameter to list jobs#1149
pstorz merged 9 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/s5120-llist-jobs-jobtype

Conversation

@alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Apr 1, 2022

Description

This PR gives the (l)list jobs command the ability to filter jobs based on their jobtype.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5120-llist-jobs-jobtype branch 9 times, most recently from 1bebcdb to 8183365 Compare April 4, 2022 08:29
Copy link
Contributor

@frb121 frb121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to reword the commit message to core: add support for comma separated jobtypes on 9dc6cd7.

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5120-llist-jobs-jobtype branch from 8183365 to 1216a02 Compare April 4, 2022 11:21
@alaaeddineelamri alaaeddineelamri requested a review from frb121 April 4, 2022 11:22
Copy link
Contributor

@frb121 frb121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementation, @alaaeddineelamri . Good work!

@alaaeddineelamri alaaeddineelamri self-assigned this Apr 5, 2022
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5120-llist-jobs-jobtype branch from 1216a02 to 5b95ebc Compare April 5, 2022 15:48
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pstorz pstorz merged commit 07610ed into bareos:master Apr 6, 2022
@pstorz pstorz deleted the dev/alaaeddineelamri/master/s5120-llist-jobs-jobtype branch April 6, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants