Skip to content

jstreegrid: remove handling of IE < 8 using navigator interface to avoid warnings in chrome#1140

Merged
pstorz merged 2 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/s5113
Mar 29, 2022
Merged

jstreegrid: remove handling of IE < 8 using navigator interface to avoid warnings in chrome#1140
pstorz merged 2 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/s5113

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Mar 25, 2022 •
edited by pstorz
Loading

Starting in Chrome 101, the amount of information available in the
User Agent string will be reduced.

This PR removes the specific handling of IE < 8, to avoid issues
in Chrome >= 101.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@frb121 frb121 self-assigned this Mar 25, 2022
@frb121 frb121 requested a review from pstorz March 25, 2022 12:35
pstorz
pstorz requested changes Mar 25, 2022
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title should contain the reason why we remove that support..

Why not simply remove the code in question without extra comment?
E8 is alread 13 years old and only running on OS that are not supported anymore.

@frb121 frb121 changed the title jstreegrid: remove handling of IE < 8 using navigator interface jstreegrid: remove handling of IE < 8 using navigator interface to avoid warnings in chrome Mar 25, 2022
@frb121
Copy link
Contributor Author

frb121 commented Mar 25, 2022

Why not simply remove the code in question without extra comment? E8 is alread 13 years old and only running on OS that are not supported anymore.

It's IE < 8, which I would think nobody should use nowadays, totally agree with you. However, I kept it for now commented out in case of an upstream change of the extension, so I remember what is going on and don't re-introduce by accident.

@pstorz
Copy link
Member

pstorz commented Mar 25, 2022

It's IE < 8, which I would think nobody should use nowadays, totally agree with you. However, I kept it for now commented out in case of an upstream change of the extension, so I remember what is going on and don't re-introduce by accident.

But that is what git is for, isn't it?

@frb121
Copy link
Contributor Author

frb121 commented Mar 25, 2022

It's IE < 8, which I would think nobody should use nowadays, totally agree with you. However, I kept it for now commented out in case of an upstream change of the extension, so I remember what is going on and don't re-introduce by accident.

But that is what git is for, isn't it?

I'd like to have a clear hint, but I'm going to remove the code section.
It's not worth a discussion, let's get this done.

frb121 added 2 commits March 25, 2022 15:07
@frb121
jstreegrid: remove handling of IE < 8 using navigator interface
09f916c 
Starting in Chrome 101, the amount of information available in the
User Agent string will be reduced.

This PR removes the specific handling of IE < 8, to avoid issues
in Chrome >= 101.
@frb121
Update CHANGELOG.md
782beb8
@frb121 frb121 requested a review from pstorz March 25, 2022 14:09
pstorz
pstorz approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

This was referenced Mar 28, 2022
Merged
Merged
Merged
@pstorz pstorz merged commit fd4e2bc into bareos:master Mar 29, 2022
@frb121 frb121 deleted the dev/fbergkemper/master/s5113 branch April 21, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstorz pstorz pstorz approved these changes

Assignees

@frb121 frb121

Labels

requires backport to 19.2 requires backport to 20 requires backport to 21

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frb121 @pstorz