Merged
Conversation
Member
Author
|
Just for the record: I shot myself in the foot again with the compiler not being able to detect broken format-strings on |
94cef68 to
7107b63
Compare
7107b63 to
0c31a2b
Compare
This patch replaces the complicated pathid_cache based on htable with a much simpler one based on std::unordered_set. It also changes the interface to use uint64_t instead of char*
0c31a2b to
84e23ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch replaces the complicated
pathid_cachebased onhtablewith amuch simpler one based on
std::unordered_set. It also changes theinterface to use
uint64_tinstead ofchar*.This addresses a problem where htable broke when it grew, because the key-memory had been reused.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing