cats: include only jobtypes in list jobtotals that write data to volumes#1135
Merged
pstorz merged 2 commits intobareos:masterfrom Mar 23, 2022
frb121:dev/fbergkemper/master/s5114
Merged
cats: include only jobtypes in list jobtotals that write data to volumes#1135pstorz merged 2 commits intobareos:masterfrom frb121:dev/fbergkemper/master/s5114
list jobtotals that write data to volumes#1135pstorz merged 2 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/s5114
Conversation
pstorz
requested changes
Mar 22, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
The title says that certain job types are excluded, but in fact only certain job types are included if I look at the code. The suggested title is in the CHANGELOG.md change suggestion.
list jobtotals that write data to volumes
…lumes The list jobtotals command should only summarize jobs that have actually written to a storage. These are the jobtypes B, A, a and C. Other jobtypes like O and R should be excluded from jobtotals.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list jobtotals command should only summarize jobs
that have actually written to a storage.
These are the jobtypes B, A, a and C. Other jobtypes
like O and R should be excluded from jobtotals.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing