Conversation
In the case that normal logging is not possible, Qmsg() logs to syslog. Instead of logging with priority LOG_ERR in this case without regarding the message type, we now translate the bareos message type to a syslog priority.
b9d0336 to
a09f217
Compare
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
There's just the CHANGELOG entry missing, otherwise works like a charm.
bruno-at-bareos
approved these changes
Mar 22, 2022
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Thanks, approved ready for merge after last build
Contributor
|
@pstorz what about making also a backport to 21 as the change finally are somewhat |
Move the existing conversion for the syslog backend into the new MessageTypeToLogPriority() so we have only one common location to do the conversion.
bruno-at-bareos
approved these changes
Mar 31, 2022
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Nice improvements, making it even clearer.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case that normal logging is not possible, Qmsg() logs to syslog.
Instead of logging with severity LOG_ERR in this case without regarding
the message type, we now translate the bareos message type to a syslog
severity.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing