Skip to content

json generation: Fix some leaks and an integer overflow#1130

Merged
arogge merged 4 commits intobareos:masterfrom
arogge:dev/arogge/master/more-leaks
Jan 26, 2023
Merged

json generation: Fix some leaks and an integer overflow#1130
arogge merged 4 commits intobareos:masterfrom
arogge:dev/arogge/master/more-leaks

Conversation

@arogge
Copy link
Member

@arogge arogge commented Mar 17, 2022 •
edited by pstorz
Loading

  • fix memory-leaks in PrintConfigSchemaJson()
  • lib: avoid integer overflows in Bmicrosleep()

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@arogge arogge added the nobuild label Mar 17, 2022
@arogge arogge marked this pull request as draft March 17, 2022 15:40
@arogge arogge force-pushed the dev/arogge/master/more-leaks branch from 43ae681 to a6a53ba Compare December 14, 2022 16:21
@arogge arogge changed the title Make check-git and autochanger test work with sanitizers enabled Fix some leaks and an interger overflow Dec 14, 2022
@arogge arogge marked this pull request as ready for review December 14, 2022 16:21
@arogge arogge removed the nobuild label Dec 14, 2022
@pstorz pstorz self-requested a review December 23, 2022 13:37
@pstorz pstorz changed the title Fix some leaks and an interger overflow Fix some leaks and an integer overflow Dec 23, 2022
pstorz
pstorz approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pstorz pstorz changed the title Fix some leaks and an integer overflow json generation: Fix some leaks and an integer overflow Dec 23, 2022
@arogge
Copy link
Member Author

arogge commented Jan 13, 2023

@pstorz would you confirm the checklist items?

@pstorz pstorz force-pushed the dev/arogge/master/more-leaks branch from 13ad16c to 2090b30 Compare January 20, 2023 11:22
@arogge arogge force-pushed the dev/arogge/master/more-leaks branch 2 times, most recently from 1c7b75e to 2090b30 Compare January 26, 2023 11:01
@arogge arogge force-pushed the dev/arogge/master/more-leaks branch from 5fcbf34 to 2310ab1 Compare January 26, 2023 11:06
@arogge arogge merged commit 7e85698 into bareos:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstorz pstorz pstorz approved these changes

Assignees

@arogge arogge

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arogge @pstorz