Merged
Conversation
4f6679a to
73c35c2
Compare
pstorz
requested changes
Mar 11, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Good work!
- bareos-check-sources found some small changes, maybe they can be merged into the changing commits,
- As we now have the CVE Numbers that might make sense to refer to them.
1a8f4b6 to
b777bac
Compare
The PAM tests weren't enabled since the Python 3 transition renamed PYTHON to PYTHON_EXECUTABLE. This is now fixed. We also detect ASan builds and prepend the library to LD_PRELOAD so the tests will work in such an environment.
Fixes CVE-2022-24756
This adapts the two PAM tests to work correctly with the upcoming account checks. The test bconsole-pam will also check that authorization is checked correctly (which is not yet the case, so the test currently fails).
Fixes CVE-2022-24755 Previously, when a user logged in via PAM, Bareos did only check for authentication (i.e. the "auth" section in PAM). No authorization checks were made (the "account" section in PAM). This patch now adds the proper check. This will break existing PAM configuration!
Add an account section to the example and describe what has changed and what users should do to be able to login again.
b777bac to
9e0748a
Compare
pstorz
approved these changes
Mar 11, 2022
Add an account section to the example.
fb6e488 to
ad64a07
Compare
This was referenced Mar 11, 2022
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add authorization checks to PAM login and fix a memory leak in PAM login routines.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing