Skip to content

webui: introduce rerun of multiple jobs at once#1109

Merged
pstorz merged 5 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/s5053
Apr 11, 2022
Merged

webui: introduce rerun of multiple jobs at once#1109
pstorz merged 5 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/s5053

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Mar 9, 2022

This PR makes it possible to rerun multiple failed jobs at once from webui.

It introduces a new view (rerun) in the job module, that provides a list of
failed jobs from which a user can select which ones should be queued
for a rerun with a single button click.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@frb121 frb121 self-assigned this Mar 9, 2022
@frb121 frb121 requested a review from pstorz March 9, 2022 14:20
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rerun panel only offers failed jobs to be rerun.
I think it still makes sense to be able to rerun successful job also, as that is currently also possible.

Do we still want to keep the "rerun" job button at the normal job output, or do we want to move the rerun functionality to the "rerun" tab?

@frb121
Copy link
Contributor Author

frb121 commented Mar 24, 2022

The rerun panel only offers failed jobs to be rerun. I think it still makes sense to be able to rerun successful job also, as that is currently also possible.

Of course can we include other job status and just filter some job types like we do for the rerun action on our job tables, where it makes no sense to have a rerun, depending on its job type. I'm going to adjust it in that way.

Do we still want to keep the "rerun" job button at the normal job output, or do we want to move the rerun functionality to the "rerun" tab?

I think it's quite handy for users to have the rerun functionality in the action column on job listings as well. So I would leave that as it is for now.

@frb121 frb121 requested a review from pstorz April 7, 2022 11:29
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pstorz pstorz merged commit 47905d4 into bareos:master Apr 11, 2022
@frb121 frb121 deleted the dev/fbergkemper/master/s5053 branch April 21, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants