NDMP_BAREOS AutoXFlate support (backport PR #1013)#1090
Merged
pstorz merged 14 commits intobareos:bareos-21from Mar 1, 2022
Merged
Conversation
(cherry picked from commit c909a4f)
The ndmp systemtest now has autoxflate enabled on the storages. (cherry picked from commit 3c0430e)
- extract functions - remove unneeded switch statements - shorten too long comments (cherry picked from commit d335185)
(cherry picked from commit ddbfe19)
(cherry picked from commit 2929888)
(cherry picked from commit 3c044b6)
(cherry picked from commit 5b22a99)
(cherry picked from commit e38c2b7)
(cherry picked from commit 6099ca5)
(cherry picked from commit f54a490)
(cherry picked from commit 382f73c)
(cherry picked from commit 3be6ab6)
When doing an NDMP restore the data must be sent to the client inflated. This patch changes the autoxflate initialization so that an incompatible configuration, that might send compressed data to the client, will be overridden with safe defaults. (cherry picked from commit b8b4a4d)
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
pstorz
approved these changes
Mar 1, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Good work! Thank you very much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the backport to 21 of PR #1013
NDMP backups (using NDMP BAREOS) could be configured to use the autoxflate plugin on used storage devices
Unfortunately, the stream was not deflated during restore resulting in non-recoverable Backups.
This PR adds the feature to deflate compressed packages before sending them back to the NDMP data agent
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General