Skip to content

webui: update jquery from v3.2.0 to v3.6.0#1083

Merged
pstorz merged 2 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/jquery-update
Mar 3, 2022
Merged

webui: update jquery from v3.2.0 to v3.6.0#1083
pstorz merged 2 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/jquery-update

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Feb 24, 2022

Fixes #1430: Version of Jquery is old and vulnerable

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

Fixes #1430: Version of Jquery is old and vulnerable
@frb121 frb121 self-assigned this Feb 24, 2022
@bruno-at-bareos
Copy link
Contributor

@fbergkemper you change from plain jquery to min version, no problem to debug afterwards ?

@frb121
Copy link
Contributor Author

frb121 commented Mar 1, 2022

@fbergkemper you change from plain jquery to min version, no problem to debug afterwards ?

Production always used the minified distribution, besides having the according plain version for debugging and development purposes. This applies to every external dependencies used.

see: https://github.com/fbergkemper/bareos/blob/dev/fbergkemper/master/jquery-update/webui/module/Application/view/layout/layout.phtml.in

Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build, and tested manually doesn't show Javascript error message or malfunction.
Ready for merge

@bruno-at-bareos
Copy link
Contributor

@pstorz ok for merge

@pstorz pstorz merged commit f07e6e9 into bareos:master Mar 3, 2022
@frb121 frb121 deleted the dev/fbergkemper/master/jquery-update branch March 10, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants