Skip to content

cleanup .gitignore files#1067

Merged
arogge merged 5 commits intomasterfrom
dev/fbergkemper/master/gitignore-update
Mar 2, 2022
Merged

cleanup .gitignore files#1067
arogge merged 5 commits intomasterfrom
dev/fbergkemper/master/gitignore-update

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Feb 9, 2022 •
edited by arogge
Loading

This PR is a general clean-up of our .gitignore files.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • git status should not report modifications in the source tree after building and testing

@frb121 frb121 self-assigned this Feb 9, 2022
@frb121 frb121 requested a review from pstorz February 9, 2022 15:57
arogge
arogge reviewed Feb 9, 2022
View reviewed changes
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about:
*~
*.slo
*.lo
*.o
*.pyc
*.swp
*.so
*.dylib
*.lai
*.la
*.a
autoconf/config.log
tags
cscope.out
*/Testing*/

So maybe we want a general cleanup? I also noticed we have 16 different .gitignore files. Maybe we can also try to improve the rest of the overall situation, because it seems like there are a lot of old and unneccessary ignores.

@frb121
Copy link
Contributor Author

frb121 commented Feb 9, 2022

What about: *~ *.slo *.lo *.o *.pyc *.swp *.so *.dylib *.lai *.la *.a autoconf/config.log tags cscope.out */Testing*/

So maybe we want a general cleanup? I also noticed we have 16 different .gitignore files. Maybe we can also try to improve the rest of the overall situation, because it seems like there are a lot of old and unneccessary ignores.

Good point, I'd fully agree on a general clean-up.

@frb121 frb121 changed the title Update .gitignore cleanup .gitignore files Feb 9, 2022
@frb121 frb121 force-pushed the dev/fbergkemper/master/gitignore-update branch from 1189264 to 64e0c8f Compare February 9, 2022 19:38
@frb121 frb121 added the nobuild label Feb 9, 2022
@frb121 frb121 marked this pull request as draft February 9, 2022 19:41
@frb121 frb121 removed the request for review from pstorz February 9, 2022 19:46
@frb121 frb121 force-pushed the dev/fbergkemper/master/gitignore-update branch from 64e0c8f to 1e15ca3 Compare February 9, 2022 19:49
@frb121 frb121 force-pushed the dev/fbergkemper/master/gitignore-update branch 3 times, most recently from 7dbcad6 to 8da0376 Compare February 21, 2022 16:15
@frb121 frb121 marked this pull request as ready for review February 21, 2022 16:59
@frb121 frb121 requested a review from arogge February 21, 2022 17:00
@frb121 frb121 removed the nobuild label Feb 21, 2022
@frb121 frb121 force-pushed the dev/fbergkemper/master/gitignore-update branch from f3fb7bd to b120b66 Compare March 2, 2022 11:56
frb121 and others added 4 commits March 2, 2022 12:59
@frb121
gitignore: merge and centralize .gitignore files
deac078
@frb121
gitignore: remove and sort entries alphabetically
b551968 
- remove development environment specific entries
- remove old relicts and unnecessary entries
- remove duplicates and unused entries
- sort alphabetically
@arogge @frb121
gitignore: autogenerate parts of the gitignore file
6df9878
@frb121
Update CHANGELOG.md
b46b9bb
@frb121 frb121 force-pushed the dev/fbergkemper/master/gitignore-update branch from b120b66 to b46b9bb Compare March 2, 2022 11:59
@arogge
webui: don't install data directory
7c9529c 
The data directory was unused and implicitly removed by removing its
.gitignore, so we cannot install it anymore.
Also remove it from .gitignore.
@arogge arogge merged commit 9064271 into master Mar 2, 2022
@arogge arogge deleted the dev/fbergkemper/master/gitignore-update branch March 2, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arogge arogge arogge approved these changes

Assignees

@frb121 frb121

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frb121 @arogge