Merged
Conversation
9539e13 to
df2b9bb
Compare
pstorz
requested changes
Feb 3, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Looks very good and works as expected. I shortened the PR name a bit (and updated the CHANGELOG accordingly).
It would make sense to move the "client" based timeline on the right, and put the job based timeline on the left of the menu. I.e. the jobs based one is the default.
Good work"
4644f50 to
2699196
Compare
Contributor
Author
Thanks for the review. |
Contributor
Author
|
I've made the changes we discussed elsewhere yesterday, please have another look at the PR. Thank you. |
0855eeb to
f5a3580
Compare
- introduce timelinejobs controller action - introduce endpoint all-job-resources - introduce endpoint job-timeline - rename endpoint timeline to client-timeline
- introduce getJobsForPeriodByJobname method
- introduce nav-tabs clients and jobs - introduce changeNoDataText function - change wording in some places - fix css indentation - change modal-004 size - adjust customized chart tooltip
- move redundant JS from views to timeline.js
- move redundant CSS from views to timeline.css
f5a3580 to
62f9d45
Compare
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If multiple jobs are defined for one client, it makes sense to be able
to show the timeline based on jobs and not on clients.
Therefore, this PR introduces some changes to have a timeline chart
for clients in the clients module and a timeline chart for jobs in the
job module available.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing