Fix context issue in bareos-dir python plugin#1047
Merged
arogge merged 3 commits intobareos:masterfrom Feb 18, 2022
Merged
Conversation
pstorz
requested changes
Feb 4, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Very good work!
Only the CHANGELOG.md entry is missing.
3c1b118 to
e7948da
Compare
Previously when running multiple jobs concurrently, the python plugin would not always set the right context before running the python callback function. This patch makes the context thread_local and resets it before every callback.
This patch lets the test run multiple jobs in parallel and checks that each plugin callback sees the correct plugin context.
e7948da to
1f2263b
Compare
1f2263b to
c3557d0
Compare
This was referenced Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test that exposes a bug in python-dir's context handling and provides an appropriate fix.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests