Conversation
9ef75c6 to
de80a2b
Compare
bruno-at-bareos
requested changes
Jan 17, 2022
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
- Subject and maybe title can be still a bit optimized
- Some smalls changes (cosmetic on indentation)
..._config_directive_descriptions/dir-director-NdmpNamelistFhinfoSetZeroForInvalidUquad.rst.inc
Outdated
Show resolved
Hide resolved
pstorz
commented
Jan 18, 2022
cd1bd61 to
d2a9649
Compare
bruno-at-bareos
requested changes
Jan 18, 2022
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
I propose to add clearly the default value for the documentation
bruno-at-bareos
approved these changes
Jan 18, 2022
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Everything is ok, just the changelog entry need to be added.
23729e3 to
d2a9649
Compare
bruno-at-bareos
previously requested changes
Feb 3, 2022
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
There's 2 suggestions to apply to align version to 20.0.6 as we do the backport to 20.
Then a CHANGELOG commit is needed.
docs/manuals/source/include/autogenerated/bareos-dir-config-schema.json
Outdated
Show resolved
Hide resolved
11 tasks
16 tasks
The isilon 9.1.0.0 release seems to have added a sanity check in ndmp that checks that the tape offsets are on 512B boundaries. The following error is issued when a restore is triggered to a isilon 9.1.0.0 system: 'Invalid nlist.tape_offset -1 at index 1 - tape offset not aligned at 512B boundary' However, -1 is an allowed value (NDMP_INVALID_U_QUAD) and was accepted on every NDMP implementation we tested against including older isilon versions. To fix the problem, the isilon needs to check for NDMP_INVALID_U_QUAD before it checks for the 512B boundary to fix the problem. Otherwise we could enable this workaround depending on a new configuration option.
…hema.json Co-authored-by: Bruno Friedmann @bareos <89836284+bruno-at-bareos@users.noreply.github.com>
Co-authored-by: Bruno Friedmann @bareos <89836284+bruno-at-bareos@users.noreply.github.com>
b3f00f8 to
5f834bd
Compare
5f834bd to
3fb1f1d
Compare
arogge
approved these changes
Feb 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The isilon 9.1.0.0 release seems to have added a sanity check in ndmp
that checks that the tape offsets are on 512B boundaries.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests