sql_get.cc: fix error logging in GetJobRecord() for jobname#1042
Merged
sql_get.cc: fix error logging in GetJobRecord() for jobname#1042
Conversation
bruno-at-bareos
previously requested changes
Jan 11, 2022
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
A separate commit for CHANGELOG.md is missing
This PR logs the jobname if GetJobRecord() fails when searching for a jobname.
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
3237869 to
7809794
Compare
CHANGELOG.md change was added
bruno-at-bareos
approved these changes
Jan 13, 2022
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Everything is now fine. Ready for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR logs the jobname if GetJobRecord() fails when searching for a jobname.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingno need for tests.