dird: extend the list command to be able to query volumes and pools by ID#1041
Merged
pstorz merged 8 commits intobareos:masterfrom Jan 19, 2022
Conversation
6bc300f to
a78b8aa
Compare
franku
reviewed
Jan 13, 2022
Contributor
franku
left a comment
There was a problem hiding this comment.
Started a review. Looks good so far, pls read my comments.
a78b8aa to
73548f2
Compare
Contributor
Author
Thanks for the review @franku ! We assigned you by mistake as a reviewer, but it's the good kind of mistake :D |
Contributor
|
I'd change the PR subject to something like ... dird: extend the list command to be able to query volumes and pools by ID ... which I think is more precise. The PR description should be adjusted in that way and also mention the newly introduced arguments poolid, mediaid/volumeid, I feel. |
73548f2 to
a62304a
Compare
a62304a to
6c49b7e
Compare
frb121
reviewed
Jan 18, 2022
6c49b7e to
9a9d744
Compare
9a9d744 to
2519df9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR extends the
listcommand to give the user the ability to list volumes by ID usinglist volumeid=xxorlist mediaid=xx. Also it give the ability to list pools by Id usinglist poolid=xxPlease check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests