dir, stored: start statistics threads only if needed#1040
Merged
pstorz merged 14 commits intobareos:masterfrom Feb 24, 2022
Conversation
4cf3c5d to
8591cd0
Compare
9370a04 to
e73e565
Compare
pstorz
requested changes
Jan 10, 2022
8c19271 to
ef6947b
Compare
pstorz
requested changes
Jan 13, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
The code that handles the return status of StartStatisticsThread() in both storage and director needs to be added.
Good work!
82df1d7 to
8f34523
Compare
pstorz
approved these changes
Jan 27, 2022
pstorz
requested changes
Jan 27, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Good work, however I would use M_ERROR_TERM instead of M_WARNING if the statistics thread is required but cannot be started. This probably is a serious problem.
Other than that, the last commit message could be reformatted as it has a single "s" in one line that needs to be removed.
Thank you!
21edc97 to
502f282
Compare
34f81ff to
c1c9bf3
Compare
c1c9bf3 to
ac40b3c
Compare
04d7bc6 to
d347940
Compare
added 8 commits
February 21, 2022 11:10
also refactoring addresses and ports test
d347940 to
b84df04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The director statistics thread starts even when not needed. In order to optimize and have less unnecessary workload, the statistics thread for the director is not started by default, unless
collect statisticsandstatistics collect intervalare both specified.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing