core cats: Add IF EXISTS in drop table statements#1035
Conversation
|
Question: shall we add a systemtest for checking parameter ExitOnFatal = yes ? |
|
if exists in drop table statements
if exists in drop table statementsIF EXISTS in drop table statements
The test would have to run bareos-dir with ExitOnFatal = on to check we don't introduce a new error afterwards. But this is certainly too nitpicky |
pstorz
left a comment
There was a problem hiding this comment.
Good work, makes sense. I have the following remarks:
-
The info which bug is fixed should not be part of the PR title but from the commit that fixes the bug:
See:
https://docs.bareos.org/DeveloperGuide/gitworkflow.html#commit-message-guideline -
Also, a CHANGELOG.md line is missing. There the fixed bug also should be referenced.
IF EXISTS in drop table statementsIF EXISTS in drop table statements
e1ac8fd to
080d157
Compare
|
Everything should be now fixed |
pstorz
left a comment
There was a problem hiding this comment.
The commit should contain a line
Fixes #1409: DB error on restore with ExitOnFatal=true
This will automatically link the commit with the mantis bug.
Other than this everything is fine!
080d157 to
9c483bb
Compare
- Using if exists avoid return of fatal error from database Allow the use of parameter ExitOnFatal = true on normal workflow - Fixes bareos#1409: DB error on restore with ExitOnFatal=true Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
9c483bb to
f3c94c9
Compare
Allow the use of parameter ExitOnFatal = true on normal workflow
Signed-off-by: Bruno Friedmann bruno.friedmann@bareos.com
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing