Skip to content

debian: set postgres db parameter#1031

Merged
joergsteffens merged 2 commits intomasterfrom
dev/joergs/master/dbconfig_LC_COLLATE_LC_CTYPE
Dec 22, 2021
Merged

debian: set postgres db parameter#1031
joergsteffens merged 2 commits intomasterfrom
dev/joergs/master/dbconfig_LC_COLLATE_LC_CTYPE

Conversation

@joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Dec 21, 2021

The Bareos catalog should be created with following settings:
Encoding: SQL_ASCII
Collate: C
Ctype: C
While all recent versions of dbconfig support the parameter Encoding,
Collate and Ctype are only supported in dbconfig >= 2.0.21.
On older versions, these setting is ignored.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@joergsteffens joergsteffens marked this pull request as ready for review December 21, 2021 11:12
@joergsteffens joergsteffens requested a review from arogge December 21, 2021 11:13
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready.

@arogge
Copy link
Member

arogge commented Dec 21, 2021

Please don't merge before 1032, merging the CHANGELOG.md would be even worse bad otherwise

@joergsteffens joergsteffens force-pushed the dev/joergs/master/dbconfig_LC_COLLATE_LC_CTYPE branch from d3b4848 to d98dc57 Compare December 21, 2021 14:31
The Bareos catalog should be created with following settings:
Encoding: SQL_ASCII
Collate:  C
Ctype: C
While all recent versions of dbconfig support the parameter Encoding,
Collate and Ctype are only supported in dbconfig >= 2.0.21.
On older versions, these setting is ignored.
@joergsteffens joergsteffens force-pushed the dev/joergs/master/dbconfig_LC_COLLATE_LC_CTYPE branch from d98dc57 to cb42b42 Compare December 22, 2021 10:25
@joergsteffens joergsteffens merged commit ef4f9d4 into master Dec 22, 2021
@joergsteffens joergsteffens deleted the dev/joergs/master/dbconfig_LC_COLLATE_LC_CTYPE branch March 10, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants