Conversation
1678635 to
322c2e5
Compare
322c2e5 to
2316dff
Compare
pstorz
requested changes
Dec 17, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
Hello,
I did the PR review and have one little comment. Also, I added one commit on top of the PR to simplify the output of the current dbdriver in the director status line.
Please also have a look at that commit.
... instead of just recommending it.
The only remaining supported catalog db driver is postgresql, so we can immediately return that value.
ec70e69 to
2eea38d
Compare
Member
Author
|
Rebased on master. |
dbdriverin all config files, templates and and config templates
dbdriverin all config files, templates and and config templatesdbdriver in all config files, templates and from automatic configuration during install
dbdriver in all config files, templates and from automatic configuration during installdbdriver from all config files, templates and from automatic configuration during install
dbdriver from all config files, templates and from automatic configuration during installdbdriver from all config files, templates and from automatic configuration during install
2eea38d to
6aa7dac
Compare
pstorz
approved these changes
Dec 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that the deprecated config directive
dbdriveris no longer used.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing, as it is now deprecated.