Skip to content

webui: client details now can be displayed for client names containing dots#1023

Merged
pstorz merged 4 commits intomasterfrom
dev/fbergkemper/master/fix-broken-clientname-link
Dec 16, 2021
Merged

webui: client details now can be displayed for client names containing dots#1023
pstorz merged 4 commits intomasterfrom
dev/fbergkemper/master/fix-broken-clientname-link

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Dec 14, 2021 •
edited by pstorz
Loading

This PR fixes a routing issues with client names that contain dots.

We now use query parameters for the link generation instead of
a route segment.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@frb121 frb121 self-assigned this Dec 14, 2021
@frb121 frb121 requested a review from pstorz December 14, 2021 14:20
pstorz
pstorz requested changes Dec 15, 2021
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, However, I think it would make sense to change the PR name to better describe what problem was fixed (From a user point of view)

e.g. webui: client details now can be displayed for client names containing dots.

Also the PR Number i missing in CHANGELOG.md

@frb121 frb121 changed the title webui: fix routing issue with client names that contain dots webui: client details now can be displayed for client names containing dots Dec 15, 2021
@frb121 frb121 force-pushed the dev/fbergkemper/master/fix-broken-clientname-link branch from 0e8bd0d to 8341a1e Compare December 15, 2021 11:47
@frb121
Copy link
Contributor Author

frb121 commented Dec 15, 2021

Good work, However, I think it would make sense to change the PR name to better describe what problem was fixed (From a user point of view)

e.g. webui: client details now can be displayed for client names containing dots.

PR subject changed to better describe the fix from user POV.

@frb121 frb121 requested a review from pstorz December 15, 2021 11:52
pstorz
pstorz approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pstorz pstorz merged commit 248a2ea into master Dec 16, 2021
@pstorz pstorz deleted the dev/fbergkemper/master/fix-broken-clientname-link branch December 16, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstorz pstorz pstorz approved these changes

Assignees

@frb121 frb121

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frb121 @pstorz @arogge