Merged
Conversation
6a492f6 to
2bc5148
Compare
ad7d270 to
a6f3bd5
Compare
446ffa8 to
4444939
Compare
pstorz
requested changes
Dec 15, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
So far looks good. I am missing a legend that describes what the colors in the timeline mean.
4444939 to
2d2c40f
Compare
Contributor
Author
I've added a legend underneath the chart. |
ae63746 to
f444c8e
Compare
f444c8e to
fe1effd
Compare
fe1effd to
c80c1cc
Compare
pstorz
approved these changes
Dec 16, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
Good work, I commited the changes by bareos-check-sources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
This PR introduces a job timeline chart.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing