Conversation
I had to update some of the autodocumentation information so that the location of code elements is specified with the full dot path. Ran all tox tasks successfully. The nocoverage tox task actually ran through now even when there is no .so file in the local clone.
This runner will be officially removed on June 30, 2025. Our tests that use it are intentionally "failing" to communicate us of this impending deprecation.
This runner was transitioned from Beta to "generally available" on 2025-04-08.
Not a surprise. It doesn't for 2022 and didn't for 2019 either.
It was in the source distribution, but not the wheel.
I was getting different Cython output when I ran with tox -r -e cythonize and tox -e cythonize. With this flag, I always get the same output regardless of how I run it or if the file was already altered.
mosesyhc
approved these changes
Jun 24, 2025
Member
mosesyhc
left a comment
There was a problem hiding this comment.
In the review, I verify that tox -e coverage/nocoverage functions as expected and refers to the correct venv. Additionally I confirmed that the src layout has now eliminated the issue where python first checks the script directory for the package.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details for this provided in Issue #150.
Note that I also had to remove the use of the Windows 2019 action runner as it will be removed soon. I took the opportunity to add in the new Windows 2025 action runner.
While this is a simple change, my PR review will be significant to ensure that we are creating packages correctly
pip show surmise>>> surmise.__version__nocoveragevenvpython -m pydoc surmisefrom the root of the repo and from my home directory to confirm that both are using the installed packagecoveragegenerates the matern.soeach time and runs correctly if I delete it beforehand.nocoveragenow runs even if I delete the.sofile in the local clone that was created by a previouscoveragerun. That file remains absent afternocoveragefinishes. I do, however, see the.sofile created in the package installation.coverageandnocoveragevenvs to confirm successful execution.rstfiles from the root of the repo, but this seems OK for that distro..sofile in it..sofile was in place. I also inspected these withotool -Lorlddand see only OS and compiler external dependencies.