FIX: Fix crash when clicking 'View all object settings'#10607
Merged
lanewei120 merged 1 commit intoMay 8, 2026
Conversation
ObjectGridTable::OnSelectCell() might get triggered without a valid m_side_window existing, guard against running the rest of the callback when m_side_window is NULL. Verified on the latest Flatpak beta build (2.6.1) with wxWidgets 3.2.9. Closes: bambulab#9423 bambulab#10015 bambulab#10178 Co-authored-by: Tine Zivic <tine.zivic@gmail.com>
Contributor
Author
|
Based off the work in #10303 |
Collaborator
|
thanks for doing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ObjectGridTable::OnSelectCell()might get triggered without a validm_side_windowexisting, guard against running the rest of the callback whenm_side_windowisNULL.Verified on the latest Flatpak beta build (2.6.1) with wxWidgets 3.2.9.
Closes: #9423 #10015 #10178