Skip to content

Commit 9f7f6a6

Browse files
committed
transfer: avoid unnecessary timeout event when waiting for 100-continue
The commit 9dd85bc unintentionally changed the way we compute the time spent waiting for 100-continue. In particular, when using a SSL client certificate, the time spent by SSL handshake was included and could cause the CURL_TIMEOUT_EXPECT_100 timeout to be mistakenly fired up. Bug: https://bugzilla.redhat.com/767490 Reported by: Mamoru Tasaka
1 parent 98292bc commit 9f7f6a6

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

RELEASE-NOTES

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ This release includes the following bugfixes:
4747
o timer: restore PRETRANSFER timing [27]
4848
o libcurl.m4: Fix quoting arguments of AC_LANG_PROGRAM [28]
4949
o appconnect time fixed for non-blocking connect ssl backends [29]
50+
o do not include SSL handshake into time spent waiting for 100-continue [32]
5051

5152
This release includes the following known bugs:
5253

@@ -97,3 +98,4 @@ References to bug reports and discussions on issues:
9798
[29] = http://curl.haxx.se/mail/lib-2011-12/0211.html
9899
[30] = http://curl.haxx.se/libcurl/c/curl_easy_setopt.html#CURLOPTACCEPTTIMOUTMS
99100
[31] = http://curl.haxx.se/mail/lib-2011-12/0133.html
101+
[32] = https://bugzilla.redhat.com/767490

lib/transfer.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2364,7 +2364,7 @@ Curl_setup_transfer(
23642364
(data->state.proto.http->sending == HTTPSEND_BODY)) {
23652365
/* wait with write until we either got 100-continue or a timeout */
23662366
k->exp100 = EXP100_AWAITING_CONTINUE;
2367-
k->start100 = k->start;
2367+
k->start100 = Curl_tvnow();
23682368

23692369
/* set a timeout for the multi interface */
23702370
Curl_expire(data, CURL_TIMEOUT_EXPECT_100);

0 commit comments

Comments
 (0)