file: use fdopen() for uploaded files if available

kdudka · kdudka · commit 1f8518c5d9aa · 2012-07-30T15:04:38.000+02:00
It eliminates noisy events when using inotify and fixes a TOCTOU issue. Bug: https://bugzilla.redhat.com/844385
diff --git a/lib/file.c b/lib/file.c
@@ -351,8 +351,12 @@ static CURLcode file_upload(struct connectdata *conn)
       failf(data, "Can't open %s for writing", file->path);
       return CURLE_WRITE_ERROR;
     }
+#ifdef HAVE_FDOPEN
+    fp = fdopen(fd, "wb");
+#else
     close(fd);
     fp = fopen(file->path, "wb");
+#endif
   }
 
   if(!fp) {

Original file line number	Diff line number	Diff line change
`@@ -351,8 +351,12 @@ static CURLcode file_upload(struct connectdata *conn)`
`351`	`351`	`failf(data, "Can't open %s for writing", file->path);`
`352`	`352`	`return CURLE_WRITE_ERROR;`
`353`	`353`	`}`
	`354`	`+#ifdef HAVE_FDOPEN`
	`355`	`+ fp = fdopen(fd, "wb");`
	`356`	`+#else`
`354`	`357`	`close(fd);`
`355`	`358`	`fp = fopen(file->path, "wb");`
	`359`	`+#endif`
`356`	`360`	`}`
`357`	`361`
`358`	`362`	`if(!fp) {`