Support [Matrix] summary endpoint#10782
Conversation
chris48s
left a comment
There was a problem hiding this comment.
Thanks for working on this.
I've left a few comments but I think this draft is in pretty good shape.
|
I'm going to deploy this shortly. I'm not sure if making the switch will be sufficient to get us unbanned from matrix.org or if we'll still be getting rejected on the summary endpoint as well? We'll have to wait and see what happens (which will take a while given we now have to wait ~4 hours for the existing badges to drop out of cache). |
|
Having done a quick test, I think the block only applies to guest account registration. These should start working again once the existing images expire from cache. |
|
|
||
| const queryParamSchema = Joi.object({ | ||
| server_fqdn: Joi.string().hostname(), | ||
| fetchMode: Joi.string() |
There was a problem hiding this comment.
thanks for fixing this!
any chance we can still make this snake_case without breaking the world, though? 🙈
There was a problem hiding this comment.
All the base attributes for shields badges use camel case.
'server_fqdn' should be camel case as well but that would be a breaking change, so that's how we ended up here ;)
There was a problem hiding this comment.
Bah. I should have picked this up in review.
Tbh, this is more of a codebase-wide mess than that.
I've raised an issue at #10804 about how to approach this as a wider issue.
Refs #10776
Implements support for matrix-org/matrix-spec-proposals#3266.
Can be configured with the new parameter
fetchModeand is enforced formatrix.orgrooms.Combined with #10778 (increases cache duration by a factor of 480), the amount of requests is reduced by a factor of 1440!
The performance is much better than the current implementation (few test runs as an example):