extended EntityJenkinsContent Table to support passing of columns as props by Abhay-soni-developer · Pull Request #19951 · backstage/backstage

Abhay-soni-developer · 2023-09-14T16:09:32Z

Extended EntityJenkinsContent Table to support passing of columns as props

Hey, I just made a Pull Request!

My use case required me to show different metadata than the ones which are currently being displayed over the EntityJenkinsContent table.

…m top level to modify table. Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

backstage-goalie · 2023-09-14T16:10:00Z

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@backstage/plugin-jenkins	plugins/jenkins	patch	`v0.8.7-next.1`

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

Abhay-soni-developer · 2023-09-14T16:20:26Z

@NishkarshRaj @jhaals @awanlin @Rugvip
here is the pull request to resolve this issue #19950

github-actions · 2023-09-14T16:23:31Z

Uffizzi Preview deployment-37687 was deleted.

NishkarshRaj

API report must be re-built for the changes - please build the app locally
Vale is calling out a typo in the changeset recieve -> receive

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

Abhay-soni-developer · 2023-09-17T09:56:12Z

any updates on this please drop your feedback , so we can take this to the next level or else if its ok , we can get this merge quickly

@benjdlambert @NishkarshRaj @jhaals @awanlin

NishkarshRaj · 2023-09-18T05:48:55Z

any updates on this please drop your feedback , so we can take this to the next level or else if its ok , we can get this merge quickly

@benjdlambert @NishkarshRaj @jhaals @awanlin

https://github.com/backstage/backstage/actions/runs/6195785426/job/16821191090?pr=19951

API Report must be updated before we can proceed.

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

Abhay-soni-developer · 2023-09-19T08:13:50Z

@benjdlambert @NishkarshRaj @jhaals @awanlin @tudi2d
The API docs test which was failing, now runs successfully.
The merge is all set to be merged.

Thanks @NishkarshRaj for your consistent support.

Rugvip

Alright, thank you! 👍

Just wanna make sure we have proper types for the column prop

plugins/jenkins/src/components/BuildsPage/lib/CITable/CITable.tsx

…e can easily reuse the columns Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

Abhay-soni-developer · 2023-09-20T12:10:37Z

I have carefully considered your suggestions and made the following changes:

exported columns of CITable so we can reuse them too.
Changed props to only support TableColumn[] as Props as it is very unlikely that the TableColumn type will ever accept anything other than Project objects in the future.
api-report. md has been changed.

@benjdlambert @NishkarshRaj @jhaals @awanlin please go through this pr again.

we at Statusneo (https://statusneo.com/) highly appreciate your efforts and time. our team and stake holders are highly motivated to collaborate with you over backstage.

plugins/jenkins/src/components/BuildsPage/lib/CITable/CITable.tsx

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

Abhay-soni-developer · 2023-09-22T06:51:09Z

where are we with this pull request?
@freben @Rugvip

Rugvip

Thank you for the update, looks good! 👍

Just a couple of tweaks to the API surface

.changeset/spicy-poets-sell.md

plugins/jenkins/api-report.md

plugins/jenkins/src/components/Router.tsx

github-actions · 2023-10-03T10:17:16Z

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

Abhay-soni-developer · 2023-10-04T07:37:39Z

OK, will now resume work on the feedbacks
and will contribute to this

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

Abhay-soni-developer · 2023-10-05T09:10:44Z

@benjdlambert @Rugvip
made changes according to the feedbacks , please check this and get this merge if its all good from your side too.

Abhay-soni-developer · 2023-10-09T04:21:51Z

@benjdlambert @jhaals @awanlin @tudi2d @Rugvip
please pay some attention to this PR, because I think we are very close to closing this PR

Abhay-soni-developer · 2023-10-10T06:27:46Z

Thank you @freben are we ready to merge this now

Rugvip

Alright, let's to make the overall functionality available and we can figure out a nice way to expose the columns later

github-actions · 2023-10-10T09:19:16Z

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.19.0 release, scheduled for Tue, 17 Oct 2023.

extended EntityJenkinsContent Table to support passing of columns fro…

1a05cf3

…m top level to modify table. Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

Abhay-soni-developer requested review from a team as code owners September 14, 2023 16:09

Abhay-soni-developer requested review from Rugvip and tudi2d September 14, 2023 16:09

Abhay-soni-developer mentioned this pull request Sep 14, 2023

🚀 Feature: I want to modify EntityJenkinsContent Table column #19950

Closed

2 tasks

modified readme

78cfb4e

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

NishkarshRaj suggested changes Sep 15, 2023

View reviewed changes

changeset fix

d7b1d04

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

Abhay-soni-developer added 2 commits September 19, 2023 13:20

Merge branch 'master' into feature/jenkins/multibranch-pipeline

8d93b9b

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

api:docs

f9f3f1e

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

Rugvip requested changes Sep 19, 2023

View reviewed changes

plugins/jenkins/src/components/BuildsPage/lib/CITable/CITable.tsx Outdated Show resolved Hide resolved

api-report modified, scoped column type, exported ciTableColumns so w…

26abd48

…e can easily reuse the columns Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

Rugvip requested changes Sep 20, 2023

View reviewed changes

plugins/jenkins/src/components/BuildsPage/lib/CITable/CITable.tsx Outdated Show resolved Hide resolved

Abhay-soni-developer added 6 commits September 21, 2023 12:05

following the backstage agreed standard for exporting table columns

198d93e

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

removed ununsed import

18eaecf

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

modified api report

66681d0

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

exported columns directly

f0ee0bb

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

Merge branch 'master' into feature/jenkins/multibranch-pipeline

d699fd2

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

api report modified

3264425

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

Rugvip requested changes Sep 26, 2023

View reviewed changes

.changeset/spicy-poets-sell.md Outdated Show resolved Hide resolved

plugins/jenkins/api-report.md Outdated Show resolved Hide resolved

plugins/jenkins/api-report.md Outdated Show resolved Hide resolved

plugins/jenkins/src/components/Router.tsx Outdated Show resolved Hide resolved

github-actions bot added the stale label Oct 3, 2023

github-actions bot removed the stale label Oct 4, 2023

Abhay-soni-developer added 3 commits October 5, 2023 14:11

changes based upon feedback from maintainers

769238d

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

new docs generated

ac64a11

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

Merge branch 'master' into feature/jenkins/multibranch-pipeline

c9abcfc

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

freben approved these changes Oct 9, 2023

View reviewed changes

Rugvip approved these changes Oct 10, 2023

View reviewed changes

Rugvip merged commit 322fe4f into backstage:master Oct 10, 2023

Conversation

Abhay-soni-developer commented Sep 14, 2023

Hey, I just made a Pull Request!

Uh oh!

backstage-goalie bot commented Sep 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changed Packages

Uh oh!

Abhay-soni-developer commented Sep 14, 2023

Uh oh!

github-actions bot commented Sep 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NishkarshRaj left a comment

Choose a reason for hiding this comment

Uh oh!

Abhay-soni-developer commented Sep 17, 2023

Uh oh!

NishkarshRaj commented Sep 18, 2023

Uh oh!

Abhay-soni-developer commented Sep 19, 2023

Uh oh!

Rugvip left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Abhay-soni-developer commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Abhay-soni-developer commented Sep 22, 2023

Uh oh!

Rugvip left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 3, 2023

Uh oh!

Abhay-soni-developer commented Oct 4, 2023

Uh oh!

Abhay-soni-developer commented Oct 5, 2023

Uh oh!

Abhay-soni-developer commented Oct 9, 2023

Uh oh!

Abhay-soni-developer commented Oct 10, 2023

Uh oh!

Rugvip left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

backstage-goalie bot commented Sep 14, 2023 •

edited

Loading

github-actions bot commented Sep 14, 2023 •

edited

Loading

Abhay-soni-developer commented Sep 20, 2023 •

edited

Loading