OpenAPI Generation for backend-common through tsoa#15038
Conversation
Signed-off-by: Aramis Sennyey <sennyeya@amazon.com>
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
| "cors": "^2.8.5", | ||
| "dockerode": "^3.3.1", | ||
| "express": "^4.17.1", | ||
| "express": "^4.18.2", |
There was a problem hiding this comment.
Do not update this one. It's kept the same across the entire repo.
| tsx: !isBackend, | ||
| dynamicImport: true, | ||
| decorators: true, | ||
| decoratorsBeforeExport: true, |
There was a problem hiding this comment.
We are not ready to put in decorator support; this particular change will unfortunately be rejected. We want to postpone until we know more where the TS ecosystem lands in regards to this, and would need VERY good reason to add it at this point.
There was a problem hiding this comment.
👍 , makes sense. Similarly, where does the project land on IoC (Inversion of Control), https://github.com/backstage/backstage/pull/15038/files#diff-bcf7cd81750d2e438f7dc4b53af26cf084dc7323499cb498132ad9749ce959e3R1?
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Signed-off-by: Aramis Sennyey sennyeya@amazon.com
Hey, I just made a Pull Request!
✔️ Checklist
Signed-off-byline in the message. (more info)