Conversation
This reverts commit 033ba5a.
6fe90ea to
cfad1d3
Compare
ca91f3c to
c288422
Compare
SebastianElvis
approved these changes
Aug 8, 2024
Contributor
SebastianElvis
left a comment
There was a problem hiding this comment.
That's a lot. Great work!
bap2pecs
approved these changes
Aug 8, 2024
Contributor
bap2pecs
left a comment
There was a problem hiding this comment.
love this PR! great work
Contributor
Author
|
thanks for latest round of comments @SebastianElvis @bap2pecs, have addressed these |
bap2pecs
approved these changes
Aug 8, 2024
Contributor
bap2pecs
left a comment
There was a problem hiding this comment.
thanks for the changes! look great. feel free to ship the code
This was referenced Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the finality gadget server, a stateful program used to track consecutive quorum and query the latest BTC-finalized block.
Integration tests are seperately added in the
finality-providerrepo (see below)Test plan
To run tests:
To run the finality gadget daemon:
Note that running the daemon with the default configs will throw a
block %d be finalized according to client but is noterror, because there aren't any FPs signing blocks, i.e. blocks are not registered as finalized. For testing purposes, we can overridequeryIsBlockBabylonFinalizedinfinalitygadget.goto returntrue, nilfor now.one the daemon is running, we can use Postman to test gRPC (need to import the
finalitygadget.protofile) withlocalhost:8080as the URL:then you can invoke queries like:
