Skip to content
This repository was archived by the owner on Jan 30, 2026. It is now read-only.

feat: add ci job to push docker image#15

Merged
lesterli merged 6 commits intofeat/babylon-rfcfrom
feat/ci-push-docker-image
Oct 11, 2024
Merged

feat: add ci job to push docker image#15
lesterli merged 6 commits intofeat/babylon-rfcfrom
feat/ci-push-docker-image

Conversation

@lesterli
Copy link
Copy Markdown

@lesterli lesterli commented Oct 8, 2024

Summary

This PR creates a GH workflow to build and push the docker image to Babylon docker hub.

  • For new PR, the docker image will be tagged with the PR's commit hash.
  • For new tag, the docker image will be tagged with the tag's version.

Test Plan

  • Check this PR's CI job, the docker image's tag should be the PR's commit hash
  • Create a release with the tag(e.g. v0.100901.2), and then check the CI job or the docker hub, the docker image's tag should be the tag's value.

@bap2pecs
Copy link
Copy Markdown

bap2pecs commented Oct 9, 2024

@lesterli ok the new commit doesn't work jfyi

@lesterli lesterli marked this pull request as ready for review October 9, 2024 06:30
@bap2pecs
Copy link
Copy Markdown

bap2pecs commented Oct 9, 2024

For new PR, the docker image will be tagged with the PR's commit hash.

for this I see the new img 3f38804 added

image

For new tag, the docker image will be tagged with the tag's version.

how did you test this one?

@lesterli
Copy link
Copy Markdown
Author

For new tag, the docker image will be tagged with the tag's version.

how did you test this one?

Tested it in my forked repo. After releasing with a tag, it successfully triggered the docker image build with the tag version.

@lesterli lesterli merged commit 7914128 into feat/babylon-rfc Oct 11, 2024
@lesterli lesterli deleted the feat/ci-push-docker-image branch October 11, 2024 03:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants