Skip to content
This repository was archived by the owner on Jan 30, 2026. It is now read-only.

feat: add integration workflow#14

Merged
bap2pecs merged 3 commits intofeat/babylon-rfcfrom
bourne/add_integration_workflow
Oct 8, 2024
Merged

feat: add integration workflow#14
bap2pecs merged 3 commits intofeat/babylon-rfcfrom
bourne/add_integration_workflow

Conversation

@bournezjc
Copy link
Copy Markdown

@bournezjc bournezjc commented Oct 7, 2024

Summary

This PR adds a new integration workflow, triggered by either push, pull request or workflow dispatch.

Test Plan

check Actions on github repository
image

image

@bournezjc bournezjc requested a review from bap2pecs October 7, 2024 15:24
@bournezjc bournezjc marked this pull request as ready for review October 7, 2024 15:32
@bap2pecs
Copy link
Copy Markdown

bap2pecs commented Oct 7, 2024

nice! could you also check why lint failed? when I run make lint-go locally it passes with no error

my golangci-lint version

$ golangci-lint --version                                                                                                                      [12:02:34]
golangci-lint has version 1.59.1 built with go1.22.4 from 1a55854 on 2024-06-08T22:05:49Z

@bournezjc
Copy link
Copy Markdown
Author

I am able to reproduce the same err msg on my end. My lint version is

$ golangci-lint --version
golangci-lint has version 1.61.0 built with go1.23.1 from a1d6c560 on 2024-09-09T17:44:42Z

@bap2pecs
Copy link
Copy Markdown

bap2pecs commented Oct 8, 2024

ah ok. can u try to downgrade the version on CI?

the goal is we want to avoid modifying OP's code as much as possible

@bournezjc bournezjc force-pushed the bourne/add_integration_workflow branch from 41a4ae5 to 0c27127 Compare October 8, 2024 03:37
@bournezjc
Copy link
Copy Markdown
Author

Downgraded to v1.59.1, looks good to me.
image

Copy link
Copy Markdown

@bap2pecs bap2pecs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited Hype - JJptubufblBJP3E3DK

@bap2pecs bap2pecs merged commit 1bc2e10 into feat/babylon-rfc Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants