Add noUninitializedPrivateFieldAccess assumption docs#2865
Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom Feb 28, 2024
Merged
Conversation
✅ Deploy Preview for babel-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nicolo-ribaudo
commented
Feb 26, 2024
| return MyClass.#id; | ||
| } | ||
| } | ||
| ``` |
Member
Author
There was a problem hiding this comment.
Without assumption:
class MyClass {
method() {
return _id._;
}
}
var _id = {
_: 123
};With assumption:
class MyClass {
method() {
return _id;
}
}
var _id = 123;
9 tasks
✅ Deploy Preview for babel ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
noUninitializedPrivateFieldAccess assunption docsnoUninitializedPrivateFieldAccess assumption docs
JLHwung
approved these changes
Feb 26, 2024
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
Can you add a note that this assumption is supported since 7.24.0?
Co-authored-by: Brian Ng <bng412@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs for babel/babel#16267