Fix docs for static property builder#2071
Merged
existentialism merged 1 commit intobabel:masterfrom Jul 25, 2019
Merged
Conversation
|
Deploy preview for babel ready! Built with commit e2b39ae |
JLHwung
approved these changes
Jul 25, 2019
suchipi
requested changes
Jul 25, 2019
Member
suchipi
left a comment
There was a problem hiding this comment.
This doesn't work in the latest version. Maybe this is in master but hasn't been published yet?
To test, I went here: https://npm.runkit.com/@babel/types
and used this code block:
const t = require("@babel/types")
t.classProperty(t.identifier("foo"), t.stringLiteral("bar"), null, [], false, true)and it throws an error:
Error: ClassProperty: Too many arguments passed. Received 6 but can receive no more than 5
Contributor
Author
|
@suchipi It was recently merged not published yet, check related PR. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix docs for
t.classPropertybuilder to acceptstaticargument