This repository was archived by the owner on May 19, 2018. It is now read-only.
Merged
Conversation
existentialism
approved these changes
Jul 20, 2017
Contributor
Author
|
Thanks for the quick review! I assume I'll need to put up a similar PR against 6.x? |
Member
|
@jbrown215 yeah, can backport to 6.x after this lands. may also want to add support for |
This was referenced Jul 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flow v0.49 added parser support for opaque type aliases. Recently, in this commit, Flow finalized the parser changes for opaque type aliases.
The syntax is:
(export?) opaque type alias <identifier>(: <super-type>?) = <impltype>where export and the supertype are optional.
If we are in a declare, we do not parse the impltype. So the syntax in a declare is:
declare (export?) opaque type alias <identifier>(: <super-type>?)