This repository was archived by the owner on May 19, 2018. It is now read-only.
Distinguish between ternary's : and arrow fn's return type#596
Merged
nicolo-ribaudo merged 4 commits intobabel:masterfrom Sep 25, 2017
nicolo-ribaudo:issue-58-ternary-arrow-flow
Merged
Distinguish between ternary's : and arrow fn's return type#596nicolo-ribaudo merged 4 commits intobabel:masterfrom nicolo-ribaudo:issue-58-ternary-arrow-flow
nicolo-ribaudo merged 4 commits intobabel:masterfrom
nicolo-ribaudo:issue-58-ternary-arrow-flow
Conversation
2 tasks
existentialism
approved these changes
Jun 28, 2017
Member
Author
|
I rebased to resolve the merge conflicts. I squashed the commits because, since I wrote an implementation of the logic to avoid throwing errors for parenthesized expressions which are not valid parameters and then totally rewrote it, I would have needed to resolve the conflicts for a lot of unuseful commits. The original commits can be found at https://github.com/nicolo-ribaudo/babylon/tree/issue-58-ternary-arrow-flow-copy |
Member
Author
|
I just pushed some minor changes (fixed three new flow errors and removed some duplicated code) |
danez
approved these changes
Aug 4, 2017
This was referenced Nov 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@hzoo This is #573 but without flow errors. Apart from 5f176cb, this code has already been reviewed.