This repository was archived by the owner on May 19, 2018. It is now read-only.
Closed
Conversation
don't ignore compiled files
f9a6cfb to
23ff430
Compare
| "name": "x", | ||
| "decorators": [ | ||
| { | ||
| "type": "Decorator", |
Contributor
There was a problem hiding this comment.
Decorator should probably be broken into an alias of many different types.
interface Decorator <: Node {
expression: Expression;
}
interface ClassDecorator <: Decorator {
type: "ClassDecorator"
}
interface ParameterDecorator <: Decorator {
type: "ParameterDecorator"
}
// etc...
Member
|
This was auto-closed because this repo has been updated to include the Git history from the main Babel repo. It doesn't actually look like Github will let me re-open it? I can't speak to the validity of this PR, but it appears you'll need to rebase and open a new one. The new force-pused master branch should be identical to the old one, so you should be able to use |
Member
Author
|
@loganfsmyth Thanks, I'll |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because Method Parameter Decorators is now a TC39 stage 0 proposal, I'd like to propose babylon to parse parameter decorators.
While the actual transform is still being debated, it would be great if babylon only parses the syntax and allows users to transform it with third-party plugins. One concrete use case is Angular 2's decorators.
https://phabricator.babeljs.io/T1301