This repository was archived by the owner on May 19, 2018. It is now read-only.
Change location of ObjectTypeIndexer to match flow#228
Conversation
Contributor
|
We can also change the Flow parser to be consistent with Babylon. WDYT @mroch? |
Member
Author
|
I'm going to merge this for 7.0. If you still want to change flow at some point I'm happy to revert it, but I think it is more important right now to be more consistent with the flow parser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://astexplorer.net/#/TtDjoZgl57/1
The location of the
ObjectTypeIndexeris currently different in flow and babylon. Babylon includes the semicolon, whereas flow does not.Usually in all parsers for ES-Code the semicolon/colon is always included, like in ClassProperties and ObjectProperties.
So I'm not sure if we should do this, because it is not super consistent, but it would be inline with the flow parser then.
//cc @samwgoldman @gabelevi @mroch