This repository was archived by the owner on May 19, 2018. It is now read-only.
Rephrase "assigning/binding to rvalue" errors to include context (#119)#123
Merged
hzoo merged 4 commits intobabel:masterfrom Sep 22, 2016
Merged
Rephrase "assigning/binding to rvalue" errors to include context (#119)#123hzoo merged 4 commits intobabel:masterfrom
hzoo merged 4 commits intobabel:masterfrom
Conversation
Current coverage is 94.46% (diff: 100%)@@ master #123 diff @@
==========================================
Files 19 19
Lines 3105 3110 +5
Methods 327 327
Messages 0 0
Branches 816 817 +1
==========================================
+ Hits 2932 2938 +6
Misses 94 94
+ Partials 79 78 -1
|
Member
|
I think it looks good overall? there's a merge conflict atm traceur does: What are the possible left hand values (Identifier/MemberExpression)? - maybe we can suggest that |
Contributor
Author
|
Working on that merge conflict now. |
Contributor
Author
|
FWIW, I'm personally not crazy about the idea of adding bits of code to error messages, for a number of reasons (though it's probably a matter of taste more than anything).
|
72cc7ee to
85b22d0
Compare
Member
fair enough |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces all "Assigning to rvalue" and "Binding rvalue" errors with more detailed variants based on the example in #119.
The implementation is the most straightforward one I could come up with - I add an optional context argument to
checkLVal,toAssignableandtoAssignableList, a simple string which is interpolated into the final error message (if any).In some cases I made decisions that make the messages more informative in my view - e.g. making
ArrayPatternpass through any parent context, so errors look like "invalid left-hand side in assignment expression" rather than "invalid left-hand side in array destructuring pattern".Notes
contextDescriptionleftwards in the methods' parameter lists, to avoid all those addedundefineds. If there's a specific signature you'd like to see here - please let me know.