Skip to content

Split @babel/runtime into 2 modules via @babel/runtime-corejs2 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danez merged 6 commits into from
Mar 23, 2019
Merged

Split @babel/runtime into 2 modules via @babel/runtime-corejs2 #71

danez merged 6 commits into from
Mar 23, 2019

Conversation

@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Aug 10, 2018

@nicolo-ribaudo nicolo-ribaudo added the enhancement New feature or request label Aug 10, 2018
@nicolo-ribaudo nicolo-ribaudo requested a review from hzoo August 10, 2018 07:25
hzoo
hzoo reviewed Aug 10, 2018
View reviewed changes
Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the original runtime? Don't need both. But it depends on if they want corejs or not. Technically if they used helpers true or false, or polyfill true/false it would be different as well but it gets complicated haha

And what happens if you use transform-runtime with options already?

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Aug 11, 2018

I updatet the PR:

  • Don't duplicate the runtime in the dependencies
  • Replace runime -> runtime-corejs only when the old version did already inclue the runtime: 
    @babel/runtime: 7.0.0-beta.35 -> @babel/runtime-corejs
@babel/runtime: 7.0.0-rc.1 -> @babel/runtime
  • Only add the corejs option when upgrading from Babel 6. Display a warning for Babel 7 since it could be an old beta with corejs included in babel/runtime.

existentialism
existentialism reviewed Aug 28, 2018
View reviewed changes
src/upgradeConfig.js Outdated
) {
// 7.0.0-alpha.5 <= x <= 7.0.0-beta.55
console.warn(
"Babel was not able to infer dedice wether or not to add a "
Copy link
Member

@existentialism existentialism Aug 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Babel was not able to decide whether or not to add a

@nicolo-ribaudo nicolo-ribaudo force-pushed the runtime-corejs2 branch 2 times, most recently from 47c8291 to 6762617 Compare August 28, 2018 14:00
@danez danez merged commit fee7a47 into babel:master Mar 23, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the runtime-corejs2 branch March 23, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@existentialism existentialism existentialism left review comments

@hzoo hzoo hzoo left review comments

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolo-ribaudo @existentialism @hzoo @danez