Merged
Conversation
Member
Author
|
I realized that we were actually not running some module tests correctly because the imported modules were not transformed. We may be able to merge this PR to facilitate adding a CI for Babel 8. |
Merged
liuxingbaoyu
commented
May 27, 2025
| const cacheKey = sha1(JSON.stringify({ attrs, file })); | ||
|
|
||
| try { | ||
| contents = transpile(contents, { features: attrs.features, isModule, isStrict: false }); |
Member
Author
There was a problem hiding this comment.
isStrict: false Is this a bug?
liuxingbaoyu
commented
May 27, 2025
Comment on lines
+16
to
+35
| function buildCacheHash(test) { | ||
| let { phase = "", type = "" } = test.attrs.negative || {}; | ||
| if ((phase === "early" || phase === "parse") && type === "SyntaxError") { | ||
| return sha1(test.contents); | ||
| } | ||
| const sources = dependencies | ||
| .getDependencies(test.file) | ||
| .sort() | ||
| .map(function (file) { | ||
| if (file === path.basename(test.file)) { | ||
| return; | ||
| } | ||
| return dependencies.rawSource.get(path.basename(file)); | ||
| }) | ||
| .filter(Boolean); | ||
|
|
||
| sources.push(test.contents); | ||
|
|
||
| return sha1(sources.join("\n")); | ||
| } |
Member
Author
There was a problem hiding this comment.
Now it uses the same method as eshost to get dependencies, which is safe enough to merge. :)
JLHwung
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compilation results are not cached, which ensures that Babel changes are reflected in a timely manner.
There is a simple list to skip caching for tests that use other files.