Skip to content

Prevent comparision on CircleCI master#16

Merged
nicolo-ribaudo merged 2 commits intobabel:masterfrom
jbhoosreddy:detect-circleci-master
Nov 6, 2019
Merged

Prevent comparision on CircleCI master#16
nicolo-ribaudo merged 2 commits intobabel:masterfrom
jbhoosreddy:detect-circleci-master

Conversation

@jbhoosreddy
Copy link
Copy Markdown
Collaborator

@jbhoosreddy jbhoosreddy commented Oct 22, 2019

Summary of changes

  1. So it's quite tricky to conditionally running steps only on master or PR. Instead of going down that sparsely documented rabbithole, I've decided to cut my losses short and implement the conditional check inside node.
  2. Failing tests on CircleCI were being ignored because they were causing cache miss from previous job. Luckily, I've updated the job to show comparison diagnostics, so it made things more obvious!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants