Skip to content

Fix failing main#903

Merged
JLHwung merged 3 commits intomainfrom
fix-failing-main
Apr 20, 2021
Merged

Fix failing main#903
JLHwung merged 3 commits intomainfrom
fix-failing-main

Conversation

@JLHwung
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung commented Apr 20, 2021

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: update test to reflect on webpack 5 behaviour.

In some versions between webpack 5.4 and webpack 5.34, the sources of source map object have different order. The entry file was placed first in 5.4, but now it is placed at last in 5.34.

This PR updates webpack version and the assertions.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information:

@JLHwung JLHwung added the dependencies Pull requests that update a dependency file label Apr 20, 2021
@JLHwung JLHwung requested a review from hzoo April 20, 2021 20:03
Copy link
Copy Markdown
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird..

@JLHwung JLHwung merged commit f3538d0 into main Apr 20, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the fix-failing-main branch April 21, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants