use modules false to enable webpack tree shaking#617
Closed
pravdomil wants to merge 3 commits intobabel:masterfrom
pravdomil:patch-1
Closed
use modules false to enable webpack tree shaking#617pravdomil wants to merge 3 commits intobabel:masterfrom pravdomil:patch-1
pravdomil wants to merge 3 commits intobabel:masterfrom
pravdomil:patch-1
Conversation
Member
|
Could you please add a note in the README to clarify why we need it? Also that won't work a certain version of Webpack. |
Author
|
@xtuc can you take a look at it? |
Member
|
Yes that better, could you please indicate which version of Webpack is required for |
Author
|
I think that webpack supports es6 modules from the beginning? |
|
This doesn't fix anything. I'm still getting |
Member
|
This should be all set with #660 now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by default all modules are transpiled to
commonjstherefore they cannot be statically analysed and tree shaking will not worksee https://stackoverflow.com/questions/45384170/how-to-fix-modules-with-moduleconcatenation-bailout-module-is-not-an-ecmascrip