Skip to content

Revert #1055 ("use module.findPackageJSON API")#1066

Merged
nicolo-ribaudo merged 1 commit intomainfrom
revert-1055
Mar 9, 2026
Merged

Revert #1055 ("use module.findPackageJSON API")#1066
nicolo-ribaudo merged 1 commit intomainfrom
revert-1055

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Mar 9, 2026

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Docs update
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

This PR reverts #1055. Per Node.js docs, module.findPackageJSON does not support custom resolve hooks, which Yarn PnP may depends on.

Other information:

Fixes #1065.

@nicolo-ribaudo nicolo-ribaudo changed the title revert #1055 Revert #1055 ("use module.findPackageJSON API") Mar 9, 2026
@nicolo-ribaudo nicolo-ribaudo merged commit a0a2617 into main Mar 9, 2026
32 checks passed
@nicolo-ribaudo
Copy link
Member

Released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Module build failing when upgrading to 10.1.0

2 participants