Throw on empty params/args list in typescript#9968
Closed
danez wants to merge 1 commit intobabel:masterfrom
danez:ts-args-params
Closed
Throw on empty params/args list in typescript#9968danez wants to merge 1 commit intobabel:masterfrom danez:ts-args-params
danez wants to merge 1 commit intobabel:masterfrom
danez:ts-args-params
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10777/ |
|
|
||
| export default { | ||
| TS_ERR_0001: { | ||
| code: "TS_ERR_0001", |
Member
There was a problem hiding this comment.
I would prefer this to be a Symbol(), to prevent people from relying on them. We should discuss if we want to give every error a public code, or to keep it internal.
Contributor
|
What is the status? Can I work on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure about the error codes. I need to add error codes to the message, so that I can allow them to throw in
tsTryAndCatch. I didn't want to inline the codes as strings, so I went for a file containing the code and the message. It would be nice to have something like TS const enums so they could be inlined in the published code, but we do not have that. Open for suggestions.