Add back types to preset-env#9687
Merged
nicolo-ribaudo merged 14 commits intobabel:update-to-core-js-3from Mar 19, 2019
Merged
Conversation
zloirock
reviewed
Mar 14, 2019
| export type ModuleOption = $Values<typeof ModulesOption>; | ||
| export type BuiltInsOption = $Values<typeof UseBuiltInsOption>; | ||
|
|
||
| type CorejsVersion = 2 | 3; |
Member
There was a problem hiding this comment.
If can be also false, string and allow minor versions like corejs: '3.1'.
Member
There was a problem hiding this comment.
Moreover, finally, it's semver instance.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10526/ |
Member
|
@nicolo-ribaudo working on normalize-options |
Member
Author
|
Do you think that the types in the internal plugins are needed? |
bfa90a6 to
4c24a65
Compare
3b706ad to
bbd1cc6
Compare
4c24a65 to
af67ff7
Compare
zloirock
reviewed
Mar 17, 2019
| exclude: Set<string>, | ||
| polyfillTargets: Targets, | ||
| debug: boolean, | ||
| }; |
Member
There was a problem hiding this comment.
Maybe it would be better to move it to src/types.js?
bbd1cc6 to
331e634
Compare
78b39bf to
20109ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@existentialism If you want to help you can push here, just leave a comment. We'll merge this PR to the main PR (#7646) when we are done.
Maybe not needed: