Skip to content

Add back types to preset-env#9687

Merged
nicolo-ribaudo merged 14 commits intobabel:update-to-core-js-3from
nicolo-ribaudo:core-js-3-flow
Mar 19, 2019
Merged

Add back types to preset-env#9687
nicolo-ribaudo merged 14 commits intobabel:update-to-core-js-3from
nicolo-ribaudo:core-js-3-flow

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo commented Mar 14, 2019

NOTE: This PR isn't targeting master; it's targeting update-to-core-js-3

@existentialism If you want to help you can push here, just leave a comment. We'll merge this PR to the main PR (#7646) when we are done.

  • ./available-plugins.js
  • ./filter-items.js
  • ./index.js
  • ./get-option-specific-excludes.js
  • ./debug.js
  • ./types.js
  • ./utils.js
  • ./options.js
  • ./targets-parser.js
  • ./normalize-options.js
  • ./module-transformations.js

Maybe not needed:

  • ./polyfills/regenerator/entry-plugin.js
  • ./polyfills/regenerator/usage-plugin.js
  • ./polyfills/corejs2/entry-plugin.js
  • ./polyfills/corejs2/get-platform-specific-default.js
  • ./polyfills/corejs2/built-in-definitions.js
  • ./polyfills/corejs2/usage-plugin.js
  • ./polyfills/corejs3/entry-plugin.js
  • ./polyfills/corejs3/shipped-proposals.js
  • ./polyfills/corejs3/built-in-definitions.js
  • ./polyfills/corejs3/usage-plugin.js

export type ModuleOption = $Values<typeof ModulesOption>;
export type BuiltInsOption = $Values<typeof UseBuiltInsOption>;

type CorejsVersion = 2 | 3;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If can be also false, string and allow minor versions like corejs: '3.1'.

Copy link
Copy Markdown
Member

@zloirock zloirock Mar 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moreover, finally, it's semver instance.

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Mar 14, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10526/

@existentialism
Copy link
Copy Markdown
Member

@nicolo-ribaudo working on normalize-options

@nicolo-ribaudo
Copy link
Copy Markdown
Member Author

Do you think that the types in the internal plugins are needed?

@zloirock zloirock force-pushed the update-to-core-js-3 branch from 3b706ad to bbd1cc6 Compare March 17, 2019 21:05
@nicolo-ribaudo nicolo-ribaudo changed the base branch from update-to-core-js-3 to master March 17, 2019 22:29
@nicolo-ribaudo nicolo-ribaudo changed the base branch from master to update-to-core-js-3 March 17, 2019 22:30
exclude: Set<string>,
polyfillTargets: Targets,
debug: boolean,
};
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better to move it to src/types.js?

@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review March 17, 2019 23:09
@zloirock zloirock force-pushed the update-to-core-js-3 branch from bbd1cc6 to 331e634 Compare March 19, 2019 01:50
@nicolo-ribaudo nicolo-ribaudo merged commit 48bbb4b into babel:update-to-core-js-3 Mar 19, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the core-js-3-flow branch March 19, 2019 18:08
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants