[babel8] Show filename in parse errors #9509
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59048 |
Member
|
Can you show a before/after comparison? |
Member
|
@nicolo-ribaudo I think that means we have no tests for it. |
Author
|
@nicolo-ribaudo An small reproducible example const babelParser = require('@babel/parser')
babelParser.parse('const t: any = null')
// with filename
// babelParser.parse('const t: any = null', {sourceFilename: 'path/to/input-file.js'})before after (same with before) after with filename - SyntaxError: Unexpected token (1:7)
+ SyntaxError: Unexpected token (path/to/input-file.js:1:7)
at Parser.raise (/Users/Leo/workfile/ts-demo/node_modules/@babel/parser/lib/index.js:3833:17)
at Parser.unexpected (/Users/Leo/workfile/ts-demo/node_modules/@babel/parser/lib/index.js:5145:16)
at Parser.parseVar (/Users/Leo/workfile/ts-demo/node_modules/@babel/parser/lib/index.js:7888:18)
at Parser.parseVarStatement (/Users/Leo/workfile/ts-demo/node_modules/@babel/parser/lib/index.js:7713:10)
at Parser.parseStatementContent (/Users/Leo/workfile/ts-demo/node_modules/@babel/parser/lib/index.js:7309:21)
at Parser.parseStatement (/Users/Leo/workfile/ts-demo/node_modules/@babel/parser/lib/index.js:7250:17)
at Parser.parseBlockOrModuleBlockBody (/Users/Leo/workfile/ts-demo/node_modules/@babel/parser/lib/index.js:7814:25)
at Parser.parseBlockBody (/Users/Leo/workfile/ts-demo/node_modules/@babel/parser/lib/index.js:7801:10)
at Parser.parseTopLevel (/Users/Leo/workfile/ts-demo/node_modules/@babel/parser/lib/index.js:7183:10)
at Parser.parse (/Users/Leo/workfile/ts-demo/node_modules/@babel/parser/lib/index.js:8662:17)@xtuc test case is added. |
Member
|
Babel itself already does this in so I'd be hesitant to land this because it will double up the name. |
Author
|
@loganfsmyth Can we remove the |
Member
|
The issue is that users on older versions of If we make this change, it'd probably need to be toggled with an off-by-default option. |
Author
|
@loganfsmyth You are right. And should we make this change? I means is it better to show fail filename here. If it is, I can add the option to |
Member
|
This seems nice to have, so that I get proper @JLHwung @liuxingbaoyu Given #9509 (comment), wdyt about doing this for Babel 8? |
Member
|
CI failure should be fixed by #15884. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.