Fix tdz checks in transform-block-scoping plugin#9498
Fix tdz checks in transform-block-scoping plugin#9498nicolo-ribaudo merged 10 commits intobabel:masterfrom
Conversation
| } else if (executionStatus === "after") { | ||
| return "outside"; | ||
| } else if (executionStatus === "after") { | ||
| return "inside"; |
There was a problem hiding this comment.
I think that "inside" and "outside" were swapped? To me "inside" means "inside the temporal dead zone", so "the lexical declaration is after the reference".
There was a problem hiding this comment.
Yeah looking at the code it seems that "inside" was meant as "inside valid Zone". It is easier to understand for me now after swapping.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11147/ |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10057/ |
8ab5b38 to
4b893c3
Compare
| } else if (executionStatus === "after") { | ||
| return "outside"; | ||
| } else if (executionStatus === "after") { | ||
| return "inside"; |
There was a problem hiding this comment.
Yeah looking at the code it seems that "inside" was meant as "inside valid Zone". It is easier to understand for me now after swapping.
|
Is this relevant to #7933? |
|
That issue isn't fixed by this PR. |
- Use jest's expect.toThrow/expect.not.toThrow - Add input/output tests
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
✔️
(I swear I reviewed this PR as if I wasn't the author; it's so old that I didn't remember about a single line of the code I wrote 😂)
The first two commits in this PR are at #9492; I suggest reviewing that PR first.