Only allow Identifiers, Patterns and Rest in parameters of FunctionDeclarations#9488
Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom Feb 15, 2019
danez:fix-4059
Merged
Only allow Identifiers, Patterns and Rest in parameters of FunctionDeclarations#9488nicolo-ribaudo merged 1 commit intobabel:masterfrom danez:fix-4059
nicolo-ribaudo merged 1 commit intobabel:masterfrom
danez:fix-4059
Conversation
Member
danez
commented
Feb 10, 2019
| Q | A |
|---|---|
| Fixed Issues? | Fixes #4059 |
| Patch: Bug Fix? | y |
| Major: Breaking Change? | n |
| Minor: New Feature? | n |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10036/ |
| validate: chain( | ||
| assertValueType("array"), | ||
| assertEach(assertNodeType("LVal")), | ||
| assertEach(assertNodeType("Identifier", "Pattern", "RestElement")), |
Member
There was a problem hiding this comment.
Also TSParameterProperty?
nicolo-ribaudo
approved these changes
Feb 11, 2019
existentialism
approved these changes
Feb 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.